Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-509] Add some tests for Pos.DB.Functions before refactoring #3570

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Sep 10, 2018

Description

The functions in Pos.DB.Functions were previously not unit tested. Before removing dbSerializeVersion and refactoring them, we need to make sure we don't break anything.

Linked issue

CDEC-509

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@ruhatch ruhatch force-pushed the ruhatch/CDEC-509-db-tests branch 3 times, most recently from 2801069 to 92cc89c Compare September 10, 2018 19:54
@ruhatch ruhatch force-pushed the ruhatch/CDEC-509-db-tests branch from 92cc89c to 61d56cb Compare September 10, 2018 21:54
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Really nice work!

@rvl rvl merged commit 30ea9a3 into develop Sep 10, 2018
@erikd erikd deleted the ruhatch/CDEC-509-db-tests branch September 11, 2018 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants