[CBR-414] fix demo-nix.sh to have all core nodes working

[cleverca22]

Description

Linked issue

Type of change

• 🐞 Bug fix (non-breaking change which fixes an issue)
• 🛠 New feature (non-breaking change which adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
• 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
• 🔨 New or improved tests for existing code
• ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

• I have read the style guide document, and my code follows the code style of this project.
• If my code deals with exceptions, it follows the guidelines.
• I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
• CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

• I have added tests to cover my changes.
• All new and existing tests passed.

QA Steps

Screenshots (if available)

[rvl]

Can we just change the loop to for i in {0..${toString (numCoreNodes - 1)}}?

[jmitchell]

I agree, changing the for loop range would be cleaner. Let's take the opportunity to ensure it's safe to use $i rather than $((i + ...)) or $((i - ...)) anywhere inside the loop and do that. The mixture is very confusing and prone to causing bugs like this.

[rvl]

Tested this and I no longer see Not enough stake to participate in MPC messages for the last core node in the demo cluster.

[disassembler]

LGTM!