This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1045] pkgs/generate.sh: Fix purity of script #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was returning different results on Buildkite compared to when run locally.
rvl
commented
Sep 28, 2018
disassembler
suggested changes
Sep 28, 2018
There was a problem hiding this comment.
I'd like to not carry-on with duplicating jemalloc overlay. If others deem it best to merge as-is and fix in a follow-up, I'm fine with that though. I'm also not sure how much longer we want to support nix 1 hacks.
Also, shell check is broken:
In ./pkgs/generate.sh line 8:
exec $(nix-build --no-out-link regen.nix) "$@"
^-- SC2046: Quote this to prevent word splitting.
|
|
||
| # Update this if you need a package version recently uploaded to hackage. | ||
| # Any timestamp works. | ||
| , hackageSnapshot ? "2018-07-17T09:58:14Z" |
There was a problem hiding this comment.
what happens if we run it without hackageSnapshot? I'm just wondering, because the LTS is specified in stack.yaml. Is this if the default in nixpkgs doesn't have that LTS version in it?
There was a problem hiding this comment.
This timestamp is provided as an option to stack2nix. It needs to be there so that stack2nix has reproducible results (without it, latest hackage snapshot would be used).
rvl
force-pushed
the
devops-1045-pkgs-generate-sh
branch
from
1a03584 to
b4a8980
Compare
disassembler
approved these changes
Sep 28, 2018
cleverca22
approved these changes
Sep 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was returning different results on Buildkite compared to when run locally.
Linked issue
https://iohk.myjetbrains.com/youtrack/v2/issue/DEVOPS-1045
Type of change
QA Steps