This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CO-409] Fix withConfigurations
usage of WithLogger
==> Allow pure logger to be used.
#3697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pos.Launcher.Configurations
exposes a function:which highly suggests that the caller Monad
m
could define its own logger instance and expectwithConfigurations
to leverage it for whatever logging this function must perform. However:This will fail with a hard
LoggingHandler MVar isn't initialized
which suggests that some other logger than the one provided is used.Turns out that
withConfigurations
relies onwithConfigurationsM
which perform logging in plain IO only using the given logger's name to do so.This was most likely introduced when before pure loggers and ability to log in IO were introduced and has now became obsolete.
Linked issue
[CO-409]
Type of change
Developer checklist
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.Testing checklist
QA Steps
Screenshots (if available)