Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

release/2.0.0 [DEVOPS-1141] Set an ample maximum block size for epoch boundary blocks #3867

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Nov 19, 2018

Description

This change ensures that, even if the maximum block size is reduced (and it is), the epoch boundary blocks (also called genesis blocks) are still allowed a higher maximum size.

This is a cherry-pick from #3864.

ChangeLog entry for this added in #3811.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1137
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1140
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1141

Type of change

  • Bug fix
  • New feature
  • Breaking change

QA Steps

  1. Wait for the next epoch after the maximum block size parameter has been reduced.
  2. Check that nodes are still able to validate blocks.

@rvl rvl requested review from mhuesch, avieth and a team November 19, 2018 00:28
@rvl rvl force-pushed the devops-1141-block-size branch from a29b3f5 to c4c0f21 Compare November 19, 2018 01:20
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@deepfire deepfire merged commit 02b278d into release/2.0.0 Nov 19, 2018
@rvl rvl deleted the devops-1141-block-size branch November 20, 2018 00:52
iohk-bors bot added a commit that referenced this pull request Nov 20, 2018
3874: [DEVOPS-1141] Set an ample maximum block size for epoch boundary blocks r=rvl a=rvl

## Description

This change ensures that, even if the maximum block size is reduced (and it is), the epoch boundary blocks (also called genesis blocks) are still allowed a higher maximum size.

This is a cherry-pick from #3867.

## Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1137
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1140
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1141



Co-authored-by: Samuel Leathers <[email protected]>
iohk-bors bot added a commit that referenced this pull request Dec 21, 2018
3972: Cherry-picks from release/2.0.0 branch to develop r=rvl a=rvl

These are cherry-picks of the PRs: #3811 #3816 #3817 #3831 #3846 #3867 #3879 #3883 #3919 #3934 #3936 #3946 #3962.

Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Karl Knutsson <[email protected]>
Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: Alexander Diemand <[email protected]>
Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Rupert Horlick <[email protected]>
Co-authored-by: Luke Nadur <[email protected]>
Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Co-authored-by: Samuel Leathers <[email protected]>
Co-authored-by: Jean-Christophe Mincke <[email protected]>
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants