Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ideascale): Update fields for F11 params, saves JSON artifacts | NPG-000 #661

Merged
merged 7 commits into from
Jan 23, 2024
Merged

feat(ideascale): Update fields for F11 params, saves JSON artifacts | NPG-000 #661

merged 7 commits into from
Jan 23, 2024

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Jan 23, 2024 •
edited
Loading

Description

Updates ideascale importer to use F11.
Saves JSON artifacts to output directory.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Run ideascale-importer ideascale import-all for single network
  • Run ideascale-importer ideascale import-all for mainnet and preprod

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku force-pushed the feature/ideascale-custom-fields-import branch from ee57d26 to b185adc Compare January 23, 2024 06:22
@saibatizoku saibatizoku changed the title feat(ideascale): Update fields for f11 params, saves JSON artifacts feat(ideascale): Update fields for F11 params, saves JSON artifacts | NPG-000 Jan 23, 2024
@saibatizoku saibatizoku self-assigned this Jan 23, 2024
@saibatizoku saibatizoku added the review me PR is ready for review label Jan 23, 2024
@saibatizoku saibatizoku added this to the F11-Launch milestone Jan 23, 2024
@saibatizoku saibatizoku marked this pull request as ready for review January 23, 2024 16:13
@saibatizoku saibatizoku force-pushed the feature/ideascale-custom-fields-import branch from b185adc to 1281a03 Compare January 23, 2024 16:17
@saibatizoku saibatizoku enabled auto-merge (squash) January 23, 2024 16:35
@saibatizoku saibatizoku disabled auto-merge January 23, 2024 17:10
@saibatizoku saibatizoku force-pushed the feature/ideascale-custom-fields-import branch 2 times, most recently from f4c3e22 to 1fd90bb Compare January 23, 2024 18:26
@saibatizoku saibatizoku force-pushed the feature/ideascale-custom-fields-import branch from 1fd90bb to 7919540 Compare January 23, 2024 19:03
FelipeRosa
FelipeRosa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku merged commit 8eeba8c into main Jan 23, 2024
59 of 60 checks passed
@saibatizoku saibatizoku deleted the feature/ideascale-custom-fields-import branch January 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeRosa FelipeRosa FelipeRosa approved these changes

@kukkok3 kukkok3 Awaiting requested review from kukkok3

@coire1 coire1 Awaiting requested review from coire1

Assignees

@saibatizoku saibatizoku

Labels
review me PR is ready for review
Projects
None yet
Milestone
F11-Launch
Development

Successfully merging this pull request may close these issues.
2 participants
@saibatizoku @FelipeRosa