Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-483, DDW-485] Fix missing launcher config error message and prevent orphan processes after app quit #1166

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Nov 9, 2018

This PR fixes main process error when launcher-config is missing - as in a situation where you start Daedalus using Daedalus.exe instead of the Launcher.exe on Windows.
screen shot 2018-11-09 at 16 33 31

It also fixes a problem with orphaned processes after Daedalus quits in the case of missing launcher-config as well as after realizing there is already one Daedalus instance running [DDW-485].

In the scope of the same PR Daedalus lockfile handling was updated so that instead of a silent exit 2nd Daedalus instance will show the following dialog:
screen shot 2018-11-09 at 14 48 56
screen shot 2018-11-09 at 16 31 58


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac nikolaglumac changed the title [DDW-483] Fix missing launcher config error message [DDW-483, DDW-485] Fix missing launcher config error message Nov 9, 2018
@nikolaglumac nikolaglumac changed the title [DDW-483, DDW-485] Fix missing launcher config error message [DDW-483, DDW-485] Fix missing launcher config error message and prevent orphan processes after app quit Nov 9, 2018
@nikolaglumac nikolaglumac changed the title [DDW-483, DDW-485] Fix missing launcher config error message and prevent orphan processes after app quit [DDW-483, DDW-485] Fix missing launcher config error message and prevent orphaned processes after app quit Nov 9, 2018
@nikolaglumac nikolaglumac changed the title [DDW-483, DDW-485] Fix missing launcher config error message and prevent orphaned processes after app quit [DDW-483, DDW-485] Fix missing launcher config error message and prevent orphan processes after app quit Nov 9, 2018
@nikolaglumac nikolaglumac merged commit f7ee421 into release/0.12.0 Nov 9, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-483-running-daedalus-exe-causes-a-javascript-error-on-windows branch November 9, 2018 15:36
@nikolaglumac nikolaglumac mentioned this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants