Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-490] Use a small icon for the window and a large icon for the desktop #1170

Merged
merged 4 commits into from
Nov 14, 2018

Conversation

cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented Nov 13, 2018

This PR fixes window icon issues on Linux which were a result of using high quality icon which was poorly downscaled in order to be used as a small window title bar icon.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@cleverca22 cleverca22 changed the title [DW-490] use a small icon for the window and a large icon for the .desktop [DDW-490] use a small icon for the window and a large icon for the .desktop Nov 13, 2018
@nikolaglumac nikolaglumac changed the title [DDW-490] use a small icon for the window and a large icon for the .desktop [DDW-490] Use a small icon for the window and a large icon for the desktop Nov 13, 2018
@nikolaglumac
Copy link
Contributor

@amias-iohk can you please test the Linux build once it is ready? Thanks!

Copy link
Contributor

@amias-iohk amias-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot from 2018-11-14 09-24-26

checked on ubuntu 18.10 with the gnome-shell desktop (this isn't an issue with unity) and the icons are now much better quality, screen shot from a 4k desktop. well done everyone :)

@nikolaglumac
Copy link
Contributor

@amias-iohk what about the desktop icon? Is that one looking well too?

@amias-iohk
Copy link
Contributor

image

they seem a little smaller , mainnet is old style , staging is new style

@nikolaglumac nikolaglumac merged commit f58c1fd into release/0.12.0 Nov 14, 2018
@nikolaglumac nikolaglumac deleted the dw-490 branch November 14, 2018 09:46
@nikolaglumac nikolaglumac mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants