Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #26: [macOS] DYLD_LIBRARY_PATH env var needed for dev shell #29

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Fix issue #26: [macOS] DYLD_LIBRARY_PATH env var needed for dev shell #29

merged 3 commits into from
Mar 26, 2023

Conversation

yvan-sraka
Copy link
Contributor

@yvan-sraka yvan-sraka requested a review from angerman March 13, 2023 08:51
@yvan-sraka yvan-sraka self-assigned this Mar 13, 2023
@yvan-sraka yvan-sraka linked an issue Mar 13, 2023 that may be closed by this pull request
[macOS] DYLD_LIBRARY_PATH env var needed for dev shell #26
Closed
@yvan-sraka yvan-sraka force-pushed the 26-macos-dyld_library_path-env-var-needed-for-dev-shell branch from 46f543c to fafa4d1 Compare March 13, 2023 10:55
angerman
angerman reviewed Mar 16, 2023
View reviewed changes
dynamic.nix Outdated Show resolved Hide resolved
angerman
angerman reviewed Mar 16, 2023
View reviewed changes
flake.nix Show resolved Hide resolved
angerman
angerman requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to not make that pkg-config --libs-only hack.

I still don't know why this isn't being picked up automatically, but I guess openssl is defines somewhere not as pkg-config dependency :(

@angerman angerman marked this pull request as ready for review March 26, 2023 03:35
@angerman angerman merged commit f42dc2a into main Mar 26, 2023
@angerman angerman deleted the 26-macos-dyld_library_path-env-var-needed-for-dev-shell branch March 26, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman requested changes

Assignees

@yvan-sraka yvan-sraka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] DYLD_LIBRARY_PATH env var needed for dev shell
2 participants
@yvan-sraka @angerman