Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanGit is not lorri friendly #492

Closed
michaelpj opened this issue Mar 16, 2020 · 3 comments
Closed

cleanGit is not lorri friendly #492

michaelpj opened this issue Mar 16, 2020 · 3 comments
Labels

Comments

@michaelpj
Copy link
Collaborator

After much head-banging, I think I've found that using cleanGit to filter a source will cause lorri to watch the entire git directory! (and possibly the entire rest of the directory too, I'm not sure)

See target/lorri#6 (comment) for some similar issues - I suspect that in the course of doing cleanGit we do import the whole git directory, which then lorri helpfully watches for us.

@michaelpj
Copy link
Collaborator Author

Workaround: use nix-gitignore from nixpkgs instead for a less-good version.

@codygman
Copy link

codygman commented Jun 15, 2020

I think I'm affected by this, but I think it's because of the remaining lorri issue in target/lorri#232.

It seems that that PR needs another case for copied sources added? Until then I don't think even the nix-gitignore workaround will work.

@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2022
@stale stale bot closed this as completed Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants