Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(p2p): Hermes Peer2Peer Communications with IPFS/LibP2P #236

Merged
merged 33 commits into from
Jun 25, 2024
Merged

feat(p2p): Hermes Peer2Peer Communications with IPFS/LibP2P #236

merged 33 commits into from
Jun 25, 2024

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented May 20, 2024 •
edited
Loading

Description

Add stand-alone hermes-ipfs crate to provide functionality related to p2p and IPFS.

Related Issue(s)

Description of Changes

Provides API for pin/unpin, add/get file, p2p pubsub/kv networking, and a validation mechanism for data.

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added enhancement New feature or request do not merge yet PR is not ready to be merged yet draft Draft labels May 20, 2024
@saibatizoku saibatizoku self-assigned this May 20, 2024
@saibatizoku saibatizoku force-pushed the feat/hermes-ipfs-crate branch from 889103b to f763ede Compare May 20, 2024 18:11
@saibatizoku saibatizoku marked this pull request as draft May 20, 2024 18:11
@saibatizoku saibatizoku force-pushed the feat/hermes-ipfs-crate branch 2 times, most recently from d370f90 to 43924d5 Compare May 26, 2024 17:07
@saibatizoku saibatizoku force-pushed the feat/hermes-ipfs-crate branch from 87dd4dd to 8bb2eba Compare June 2, 2024 18:04
@saibatizoku saibatizoku linked an issue Jun 2, 2024 that may be closed by this pull request
🛠️ [TASK] : Retrieve Data and Files published to IPFS with Pinning #242
Closed
@saibatizoku
feat: add hermes-ipfs crate
7dc81a6
@saibatizoku
feat: add basic node with default options
a11ca58
@saibatizoku
feat: add method to add files to ipfs
a6affd8 
* feat: add thiserror crate to dependencies
* feat: add Error for Hermes IPFS
@saibatizoku
feat: add method to get files to ipfs
ada45a3 
* chore: cleanup docs
* fix: simplify add_ipfs_file method
@saibatizoku
chore: update project dictionary
fbc213c
@saibatizoku saibatizoku force-pushed the feat/hermes-ipfs-crate branch from 8bb2eba to fbc213c Compare June 2, 2024 19:15
@saibatizoku saibatizoku changed the title [WIP] feat: Add hermes-ipfs crate feat(wip): Add hermes-ipfs crate Jun 2, 2024
@saibatizoku saibatizoku marked this pull request as ready for review June 2, 2024 19:20
@saibatizoku saibatizoku requested review from stevenj and FelipeRosa and removed request for FelipeRosa June 2, 2024 19:20
@saibatizoku
feat: add types for get/add ipfs files
5e87aa1
@saibatizoku
docs: cleanup comments
5fd7d6f
@saibatizoku
chore: cleanup
67a1421
@saibatizoku
feat(hermes-ipfs): Pin and un-pin content from IPFS (#245)
b667e05 
* feat: add pinning and un-pinning functionality

* feat: add method to check if cid is pinned

* fix: make pin removal recursive

* feat: add example add-file-with-pinning.rs

example that shows how to add, pin, unpin, and get a file from IPFS
@saibatizoku
Merge branch 'main' into feat/hermes-ipfs-crate
bea5923
@saibatizoku saibatizoku reopened this Jun 7, 2024
@stevenj stevenj marked this pull request as draft June 13, 2024 08:17
@stevenj stevenj changed the title feat(wip): Add hermes-ipfs crate feat(p2p): Hermes Peer2Peer Communications with IPFS/LibP2P Jun 13, 2024
@saibatizoku saibatizoku removed the do not merge yet PR is not ready to be merged yet label Jun 18, 2024
@saibatizoku saibatizoku marked this pull request as ready for review June 18, 2024 13:02
Mr-Leshiy
Mr-Leshiy approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 mentioned this pull request Jun 21, 2024
Open
stevenj
stevenj approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit b014949 into main Jun 25, 2024
34 checks passed
@stevenj stevenj deleted the feat/hermes-ipfs-crate branch June 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj stevenj approved these changes

@apskhem apskhem Awaiting requested review from apskhem

@bkioshn bkioshn Awaiting requested review from bkioshn

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

Assignees

@saibatizoku saibatizoku

@FelipeRosa FelipeRosa

Labels
enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Hermes Essential Modules
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Retrieve Data and Files published to IPFS with Pinning
4 participants
@saibatizoku @stevenj @FelipeRosa @Mr-Leshiy