Eliminate duplicates in transactions by address #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the transactions by address are recorded in a sequence, and not a set as before, it is necessary to eliminate duplicates before storing the indices
ecioppettini
added
bug
Closed
of course it does. If you do |
Oh, sorry. That was a mistake. I was thinking about rewards and not fees |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the transactions by address are recorded in a sequence, and not a set as before (since the pagination was included for this query), it is necessary to eliminate duplicates in inputs and outputs before adding them to the transactions by address index, as an address can be both an input and and output, causing duplicates.
This appears to be the cause of #1384, although it may still be necessary to implement a proper balance method, as the transactions don't include the fee information (I think).