remove KV pairs with duplicate keys from logs #1509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-babichenko
added
bug
slog do not take care of duplicate keys in KV list which leads to errors in log parsing, DedupDrain deals with such keys.
eugene-babichenko
force-pushed
the
remove-duplicate-kv-from-log-entries
branch
from
3a2a294 to
00c8f19
Compare
mzabaluev
reviewed
Jan 8, 2020
|
@mzabaluev I believe that this is an actual error/missing feature in the logging subsystem. There can be cases when we need to create a new task from the existing one and set an appropriate task name for the logger in this task. We can use something like |
|
Closing in favor of #1533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slogdo not take care of duplicate keys in KV list which leads to errorsin log parsing,
DedupDraindeals with such keys.Fix #1499