Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a global runtime instead of a local one and new future #1556

Merged
merged 1 commit into from
Jan 14, 2020
Merged

use a global runtime instead of a local one and new future #1556

merged 1 commit into from
Jan 14, 2020

Conversation

NicolasDP
Copy link
Contributor

@NicolasDP NicolasDP commented Jan 14, 2020 •
edited
Loading

this allows us to use tokio-compat and starts using async/await where we can in order to start the transition/update to new future.

closes #1547 and closes #1548

@NicolasDP
use a global runtime instead of a local one
5c6ca10 
this allows us to use tokio-compat and starts using async/await where
we can in order to start the transition/update to new future.

closes #1547 and #1548
@NicolasDP NicolasDP added subsys-threading code related issue with threading technical debt issue to track potential technical dept we are introducing but will need care later. A-jormungandr Area: Issues affecting jörmungandr labels Jan 14, 2020
@NicolasDP NicolasDP requested a review from mzabaluev January 14, 2020 10:54
@NicolasDP NicolasDP self-assigned this Jan 14, 2020
@NicolasDP NicolasDP changed the title use a global runtime instead of a local one use a global runtime instead of a local one and new future Jan 14, 2020
@NicolasDP NicolasDP merged commit 01d4f24 into master Jan 14, 2020
@NicolasDP NicolasDP deleted the use-default-runtime branch January 14, 2020 11:28
@NicolasDP NicolasDP mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

Assignees

@NicolasDP NicolasDP

Labels
A-jormungandr Area: Issues affecting jörmungandr subsys-threading code related issue with threading technical debt issue to track potential technical dept we are introducing but will need care later.
Projects
None yet
Milestone
No milestone
2 participants
@NicolasDP @mzabaluev