Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferred list for poldercast layer #1990

Merged
merged 8 commits into from
Mar 30, 2020
Merged

Preferred list for poldercast layer #1990

merged 8 commits into from
Mar 30, 2020

Conversation

NicolasDP
Copy link
Contributor

@NicolasDP NicolasDP commented Mar 30, 2020 •
edited
Loading

this PR contains a preferred list of nodes that can be used to build
a special layer of extra nodes that we want to keep in constant connections
with.

This is going to be useful for IOHK or operators with multiple nodes to
make sure their nodes are constantly communicating with each others.

  • once is updated, make sure the preferred list also maintain the whitelist Added whitelisting to Policy #1982;
  • depends on poldercast version 0.13.0 so we don't enter NodeIDs
  • Regarding the dependency to 0.13.0: mitigation has been added.
  • no need for whitelisting because the entries are added forcibly in the view

@NicolasDP
PoC preferred list for poldercast layer
62cc2af 
this PR contains a preferred list of nodes that can be used to build
a special layer of extra nodes that we want to keep in constant connections
with.

This is going to be useful for IOHK or operators with multiple nodes to
make sure their nodes are constantly communicating with each others.
@NicolasDP NicolasDP added enhancement New feature or request subsys-network network related A-jormungandr Area: Issues affecting jörmungandr labels Mar 30, 2020
@NicolasDP NicolasDP added this to the sprint 10 milestone Mar 30, 2020
@NicolasDP NicolasDP requested a review from a team March 30, 2020 09:30
@NicolasDP NicolasDP self-assigned this Mar 30, 2020
@NicolasDP NicolasDP marked this pull request as ready for review March 30, 2020 10:20
@NicolasDP NicolasDP changed the title PoC preferred list for poldercast layer Preferred list for poldercast layer Mar 30, 2020
danielSanchezQ
danielSanchezQ approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rinor
rinor suggested changes Mar 30, 2020
View reviewed changes
@NicolasDP NicolasDP merged commit 7a1a861 into master Mar 30, 2020
lunarpool
lunarpool reviewed Apr 1, 2020
View reviewed changes
Copy link

@lunarpool lunarpool left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_view does not work, jormungandr requests view_max instead

  layers:
    preferred_list:
      view_max: 20
      peers:

Sorry I can see rinor requested that change I probably saw old version of doc

@NicolasDP NicolasDP deleted the buddy-list branch May 16, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunarpool lunarpool lunarpool left review comments

@danielSanchezQ danielSanchezQ danielSanchezQ approved these changes

@rinor rinor rinor approved these changes

Assignees

@NicolasDP NicolasDP

Labels
A-jormungandr Area: Issues affecting jörmungandr enhancement New feature or request subsys-network network related
Projects
None yet
Milestone
sprint 10
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasDP @danielSanchezQ @rinor @lunarpool