Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process services panics into errors and exit #2812

Merged
merged 2 commits into from
Dec 14, 2020
Merged

process services panics into errors and exit #2812

merged 2 commits into from
Dec 14, 2020

Conversation

eugene-babichenko
Copy link
Contributor

No description provided.

@eugene-babichenko eugene-babichenko added bug Something isn't working A-jormungandr Area: Issues affecting jörmungandr labels Dec 11, 2020
@eugene-babichenko eugene-babichenko requested review from mzabaluev and a team December 11, 2020 12:29
@eugene-babichenko eugene-babichenko self-assigned this Dec 11, 2020
mzabaluev
mzabaluev suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Handling of panic values should not rely on assumptions even if they are almost always correct, though.

jormungandr/src/utils/task.rs Outdated Show resolved Hide resolved
@eugene-babichenko eugene-babichenko mentioned this pull request Dec 12, 2020
Closed
@eugene-babichenko eugene-babichenko merged commit fc517e4 into master Dec 14, 2020
@eugene-babichenko eugene-babichenko deleted the handle-service-panic branch December 14, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev requested changes

Assignees

@eugene-babichenko eugene-babichenko

Labels
A-jormungandr Area: Issues affecting jörmungandr bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugene-babichenko @mzabaluev