Fix issues from self review

New readme text wasn't updated to last class name & simplify & remove dead code in `CertificateVerifier`.
input-output-hk · Mar 14, 2024 · 2a36928 · 2a36928
1 parent d3236aa
commit 2a36928
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 22 deletions.
diff --git a/mithril-explorer/README.md b/mithril-explorer/README.md
@@ -42,5 +42,5 @@ make icons-font
 You can then use the icon in the js, ie if your icon name is `shield`:
 
 ```jsx
-<i className={`bi mithril mithril-shield`}></i>
+<i className={`bi mi mi-shield`}></i>
 ```
diff --git a/mithril-explorer/src/components/VerifyCertificate/CertificateVerifier.js b/mithril-explorer/src/components/VerifyCertificate/CertificateVerifier.js
@@ -20,7 +20,6 @@ const certificateChainValidationEvents = {
   started: "CertificateChainValidationStarted",
   certificateValidated: "CertificateValidated",
   done: "CertificateChainValidated",
-  unknown: "Unknown",
 };
 
 const eventPosition = {
@@ -79,26 +78,20 @@ export default function CertificateVerifier({
   }, [validationError, onChainValidationError]);
 
   useEffect(() => {
-    switch (currentStep) {
-      case certificateValidationSteps.ready:
-        setVerificationEvents([]);
-        setValidationError(undefined);
-
-        if (client && certificate) {
-          setCurrentStep(certificateValidationSteps.validationInProgress);
-
-          verifyCertificateChain(client, certificate.hash)
-            .catch((err) => {
-              console.error("Certificate Chain verification error:\n", err);
-              setValidationError(err);
-            })
-            .finally(() => setCurrentStep(certificateValidationSteps.done));
-        }
-        break;
-      case certificateValidationSteps.validationInProgress:
-      case certificateValidationSteps.done:
-      default:
-        break;
+    if (currentStep === certificateValidationSteps.ready) {
+      setVerificationEvents([]);
+      setValidationError(undefined);
+
+      if (client && certificate) {
+        setCurrentStep(certificateValidationSteps.validationInProgress);
+
+        verifyCertificateChain(client, certificate.hash)
+          .catch((err) => {
+            console.error("Certificate Chain verification error:\n", err);
+            setValidationError(err);
+          })
+          .finally(() => setCurrentStep(certificateValidationSteps.done));
+      }
     }
   }, [currentStep, client, certificate]);