Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support download binaries for macOS in E2E test #1551

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Mar 7, 2024

Content

This PR includes an update of mithril-end-to-end.

mkfiles-init.sh has been modified to take account of the OS on which the command is run. It allows to download the cardano binaries on the right OS.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Test Results

  3 files  ±0   42 suites  ±0   9m 0s ⏱️ -32s
909 tests ±0  909 ✅ ±0  0 💤 ±0  0 ❌ ±0 
998 runs  ±0  998 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9969947. ± Comparison against base commit 5024ba4.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview March 7, 2024 08:25 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 7, 2024 08:25 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detection of the platform should be automatic, which will simplify the code and avoid adding an extra configuration parameter 🙂

@dlachaume dlachaume force-pushed the damien/support-download-binaries-for-macos branch from 3eadad1 to 0836370 Compare March 7, 2024 11:42
@dlachaume dlachaume temporarily deployed to testing-preview March 7, 2024 11:48 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 7, 2024 11:48 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/support-download-binaries-for-macos branch from 0836370 to edf2380 Compare March 7, 2024 13:10
@dlachaume dlachaume marked this pull request as ready for review March 7, 2024 13:11
@dlachaume dlachaume temporarily deployed to testing-preview March 7, 2024 13:17 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 7, 2024 13:17 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -1,9 +1,18 @@
# Get the operating system
UNAME=$(uname -s) OPERATING_SYSTEM=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to put this 2 commands in the same line ?
This can be more complicated to understand than having each instruction on one line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it was already done this way in this file. I guessed it was ok

@dlachaume dlachaume force-pushed the damien/support-download-binaries-for-macos branch from edf2380 to 16ddf92 Compare March 8, 2024 10:12
@dlachaume dlachaume temporarily deployed to testing-preview March 8, 2024 10:19 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 8, 2024 10:19 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/support-download-binaries-for-macos branch from 16ddf92 to 9969947 Compare March 8, 2024 11:33
@dlachaume dlachaume temporarily deployed to testing-preview March 8, 2024 11:40 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 8, 2024 11:40 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit f7c14d3 into main Mar 8, 2024
38 checks passed
@dlachaume dlachaume deleted the damien/support-download-binaries-for-macos branch March 8, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants