-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support download binaries for macOS in E2E test #1551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The detection of the platform should be automatic, which will simplify the code and avoid adding an extra configuration parameter 🙂
3eadad1
to
0836370
Compare
0836370
to
edf2380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -1,9 +1,18 @@ | |||
# Get the operating system | |||
UNAME=$(uname -s) OPERATING_SYSTEM= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to put this 2 commands in the same line ?
This can be more complicated to understand than having each instruction on one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw it was already done this way in this file. I guessed it was ok
edf2380
to
16ddf92
Compare
16ddf92
to
9969947
Compare
Content
This PR includes an update of
mithril-end-to-end
.mkfiles-init.sh
has been modified to take account of the OS on which the command is run. It allows to download the cardano binaries on the right OS.Pre-submit checklist