Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Cardano transaction part in mithril-client-wasm/www #1555

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Enhance Cardano transaction part in mithril-client-wasm/www #1555

merged 2 commits into from
Mar 12, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Mar 7, 2024 •
edited
Loading

Content

This PR includes an update of the Javascript implementation that calls the mithril-client-wasm library.
It improves the way results are displayed and tests with more convincing data.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1552

@dlachaume dlachaume force-pushed the ensemble/enhance-www-wasm-demo branch from 46da126 to 9c7dd53 Compare March 7, 2024 17:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   8m 23s ⏱️ -8s
  911 tests ±0    911 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 000 runs  ±0  1 000 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3dec292. ± Comparison against base commit 0945639.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview March 7, 2024 17:16 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 7, 2024 17:16 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the ensemble/enhance-www-wasm-demo branch from 9c7dd53 to 69f00a4 Compare March 11, 2024 08:22
@dlachaume dlachaume marked this pull request as ready for review March 11, 2024 08:23
@dlachaume dlachaume temporarily deployed to testing-preview March 11, 2024 08:28 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 11, 2024 08:28 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the ensemble/enhance-www-wasm-demo branch from 69f00a4 to 3dec292 Compare March 12, 2024 09:27
@dlachaume dlachaume temporarily deployed to testing-preview March 12, 2024 09:34 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet March 12, 2024 09:34 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 3f4b049 into main Mar 12, 2024
38 checks passed
@dlachaume dlachaume deleted the ensemble/enhance-www-wasm-demo branch March 12, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance www demonstration in mithril-client-wasm
4 participants
@dlachaume @Alenar @jpraynaud @sfauvel