-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide latest immutable file number with certified ctx #1571
Provide latest immutable file number with certified ctx #1571
Conversation
Test Results 3 files ±0 42 suites ±0 8m 36s ⏱️ -11s Results for commit 98e7ee5. ± Comparison against base commit 9622126. This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
c0ba84d
to
58f2850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall 👍
The PR is missing the client CLI and WASM parts.
I have also left few comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- Refactor `ProtocolMessage` tests - Add tests for `CardanoTransactionsMerkleRoot` and `LatestImmutableFileNumber`
Extract the construction of the response message to make unit test on response values
…essage structure
98364df
to
98e7ee5
Compare
Content
This PR add the latest immutable file number in the sign certificate protocol message.
Pre-submit checklist
Issue(s)
Closes #1536