Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPO on-boarding guide #1579

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 19, 2024

Content

This PR includes a fix to the SPO on-boarding guide to make the second step optional but strongly recommended.
Also the mermaid diagram used in the guide has been rolled back as it does not crash anymore.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

@jpraynaud jpraynaud self-assigned this Mar 19, 2024
Copy link

github-actions bot commented Mar 19, 2024

Test Results

    3 files  ±0     42 suites  ±0   9m 35s ⏱️ - 1m 8s
  923 tests ±0    923 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 012 runs  ±0  1 012 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e5c6cb9. ± Comparison against base commit eb6f2fc.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview March 19, 2024 16:11 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet March 19, 2024 16:11 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview March 20, 2024 08:36 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet March 20, 2024 08:36 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview March 20, 2024 08:45 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet March 20, 2024 08:45 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit db98482 into main Mar 20, 2024
41 of 42 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-spo-on-boarding-guide branch March 20, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants