feat: add get_current_chain_point function to fetch chain point information
#1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update the source url of the pallas-addresses package - update the source url of the pallas-codec package - update the source url of the pallas-hardano package - update the source url of the pallas-network package - update the source url of the pallas-primitives package - update the source url of the pallas-traverse package - update the source url of the pallas-crypto package - modify the `do_get_chain_block_no` function to async and handle errors - add a new `get_chain_point` function to fetch chain point information - implement the `get_current_chain_point` function for pallas - add a new `get_current_chain_point` test function
falcucci
changed the title
get_current_chain_point function to fetch chain point informationget_current_chain_point function to fetch chain point information
falcucci
changed the title
get_current_chain_point function to fetch chain point informationget_current_chain_point function to fetch chain point information
falcucci
changed the title
get_current_chain_point function to fetch chain point informationget_current_chain_point function to fetch chain point information
- remove unnecessary commented out paths for dependencies - update versions of dependencies - reorganize feature flags for the `criterion` dependency
|
@jpraynaud thanks! I'll leave this as draft until we have pallas released, ping you up when I bump the version. |
Alenar
reviewed
May 13, 2024
ch1bo
approved these changes
May 14, 2024
Which PR would that be upstream? |
- update package versions in `cargo.lock` from `0.25.0` to `0.26.0` - change package sources in `cargo.lock` to use `crates.io-index` - update package versions in `cargo.toml` in `mithril-common` directory from `0.25.0` to `0.26.0` - add new dependencies with updated versions in `cargo.toml` in `mithril-common` directory
- update version of `mithril-common` from 0.4.4 to 0.4.5 in `cargo.lock` and `mithril-common/cargo.toml`
Alenar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submit checklist
Branch
PR
Documentation
fixes
ChainObserversupports retrieving the Chain Point of the tip of the chain #1589