Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client library for incremental Cardano database #2289

Merged
merged 59 commits into from
Feb 19, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 7, 2025

Content

This PR includes the implementation of the Cardano database client library for download, unpack and verification.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2214

@jpraynaud jpraynaud self-assigned this Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Test Results

    3 files  ±  0     52 suites  ±0   10m 31s ⏱️ -14s
1 645 tests + 47  1 645 ✅ + 47  0 💤 ±0  0 ❌ ±0 
1 929 runs  +129  1 929 ✅ +129  0 💤 ±0  0 ❌ ±0 

Results for commit c318e5b. ± Comparison against base commit 875d090.

This pull request removes 14 and adds 61 tests. Note that renamed tests count towards both.
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_error
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_message
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_none_when_not_found_or_remote_server_logical_error
mithril-client ‑ cardano_database_client::tests::list_cardano_database_snapshots_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_database_client::tests::list_cardano_database_snapshots_returns_messages
mithril-common ‑ digesters::cardano_immutable_digester::tests::reports_progress_every_5_percent
mithril-common ‑ digesters::cardano_immutable_digester::tests::reports_progress_when_total_lower_than_20
mithril-common ‑ digesters::immutable_file::tests::immutable_order_should_be_deterministic
mithril-common ‑ digesters::immutable_file::tests::list_immutable_file_can_list_incomplete_trio
…
mithril-client ‑ cardano_database_client::api::test_dependency_injector::tests::test_cardano_database_client_dependency_injector_builds
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack::download_unpack_fails_when_immutable_files_download_fail
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack::download_unpack_fails_when_target_dir_would_be_overwritten_without_allow_override
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack::download_unpack_fails_with_invalid_immutable_file_range
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack::download_unpack_succeeds_with_valid_range
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack_ancillary_file::download_unpack_ancillary_file_fails_if_no_location_is_retrieved
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack_ancillary_file::download_unpack_ancillary_file_succeeds_if_at_least_one_location_is_retrieved
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack_ancillary_file::download_unpack_ancillary_file_succeeds_when_first_location_is_retrieved
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack_ancillary_file::download_unpack_ancillary_files_sends_feedbacks
mithril-client ‑ cardano_database_client::download_unpack::tests::download_unpack_immutable_files::download_unpack_immutable_files_fails_if_one_is_not_retrieved
…

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch 5 times, most recently from 33b8638 to 290b87d Compare February 12, 2025 18:02
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 12, 2025 18:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch from 290b87d to f227348 Compare February 13, 2025 16:23
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 13, 2025 16:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 14, 2025 14:13 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch 2 times, most recently from e8184cf to 2cdb8d9 Compare February 14, 2025 18:02
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 14, 2025 18:11 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch 2 times, most recently from 1fc1152 to e57529e Compare February 17, 2025 12:05
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 17, 2025 12:14 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch from e57529e to a9f192a Compare February 17, 2025 14:47
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 17, 2025 15:15 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch from a9f192a to 3fcea9b Compare February 17, 2025 15:41
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 17, 2025 15:51 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review February 17, 2025 15:51
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch 2 times, most recently from 82decab to d38897c Compare February 18, 2025 17:14
This will allow nice documentation for the module.
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch from d38897c to 68c58fb Compare February 18, 2025 17:21
* client-snapshot from `0.1.24` to `0.1.25`
* mithril-client-cli from `0.11.0` to `0.11.1`
* mithril-client from `0.11.2` to `0.11.3`
* mithril-common from `0.5.3` to `0.5.4`
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database-restore branch from 68c58fb to c318e5b Compare February 19, 2025 10:10
@jpraynaud jpraynaud merged commit 01e15ab into main Feb 19, 2025
35 of 39 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2214-client-library-cardano-database-restore branch February 19, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Incremental Cardano DB in client library
4 participants