Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing-sanchonet network decommission #2300

Merged
merged 11 commits into from
Feb 18, 2025
Merged

testing-sanchonet network decommission #2300

merged 11 commits into from
Feb 18, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 11, 2025 •
edited
Loading

Content

This PR includes updates related to the decommissioning of the testing-sanchonet network by removing all associated references and configuration files across the codebase, CI workflows, documentation and adding a blog post announcement.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2296

@dlachaume dlachaume self-assigned this Feb 11, 2025
@dlachaume dlachaume force-pushed the dlachaume/2296/sanchonet-decommission branch 2 times, most recently from a00b8f2 to 677d99d Compare February 11, 2025 10:52
@dlachaume dlachaume marked this pull request as ready for review February 11, 2025 10:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Test Results

    4 files  ±0     59 suites  ±0   10m 41s ⏱️ -18s
1 598 tests ±0  1 598 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 902 runs  ±0  1 902 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9eb2eb9. ± Comparison against base commit e2a88ec.

♻️ This comment has been updated with latest results.

sfauvel
sfauvel approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume marked this pull request as draft February 14, 2025 09:05
jpraynaud
jpraynaud approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume marked this pull request as ready for review February 18, 2025 10:15
dlachaume and others added 11 commits February 18, 2025 11:16
@dlachaume dlachaume force-pushed the dlachaume/2296/sanchonet-decommission branch from 8c1ace7 to 9eb2eb9 Compare February 18, 2025 10:19
@dlachaume dlachaume merged commit 55987d6 into main Feb 18, 2025
37 checks passed
@dlachaume dlachaume deleted the dlachaume/2296/sanchonet-decommission branch February 18, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@olgahryniuk olgahryniuk olgahryniuk approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing-sanchonet network decommission
5 participants
@dlachaume @Alenar @sfauvel @jpraynaud @olgahryniuk