Initialize actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa52eb3.
averissimo
reviewed
Jun 27, 2024
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Pawel Rucki <[email protected]>
averissimo
reviewed
Jun 27, 2024
averissimo
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Works well with my testing after a few bugs were corrected (added as single comments so that they could be easily merged).
Great job leveraging pkgdepends for the bulk of the work 💯
I used the following 4 packages to test this out
averissimo/pkg2 (custom branch)
| averissimo/pkg1 (only main branch)
| averissimo/pkg3 (custom branch)
| pkg4=averissimo/r-pkg4 (custom branch)
Namely on averissimo/pkg2 with r-hub action
- (with a test that only works with the exact combination of branches)
I noticed that this doesn't yet support composed feature branches such as feat2@feat1. Are you planning on it?
pawelru
commented
Jun 28, 2024
pawelru
commented
Jun 28, 2024
pawelru
commented
Jun 28, 2024
pawelru
commented
Jun 28, 2024
cicdguy
approved these changes
Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.