simplify the verbatim pop up

[Polkas]

closes #102

I simplify the code by placing the observe one module deeper.
I added a comment about shinyjs::useShinyjs() needed for disabled functionality, It was always needed but not documented.

Example app:

library(teal.code)
library(teal.widgets)
library(shiny)

ui <- fluidPage(
    verbatim_popup_ui("pop1", "Warnings1"),
    verbatim_popup_ui("pop2", "Warnings2"),
    shinyjs::useShinyjs()
)

server <- function(input, output, session) {
    
    
    disabled <- reactive({
        validate(need(TRUE, "This is a validation but it is being shown!"))
        warning("test")
    })
    
    verbatim_popup_srv(
        "pop1",
        title = "boo",
        verbatim_content = reactive("Hello"),
        disabled = reactive(TRUE)
    )
    verbatim_popup_srv(
        "pop2",
        title = "boo",
        verbatim_content = reactive("Hello"),
        disabled = reactive(FALSE)
    )
}

shinyApp(ui, server)

[github-actions]

Unit Tests Summary

    1 files      9 suites   12s ⏱️
  87 tests   85 ✔️ 2 💤 0 ❌
174 runs  172 ✔️ 2 💤 0 ❌

Results for commit c88c7c4.

♻️ This comment has been updated with latest results.

[gogonzo]

This PR doesn't close #102 as validation error is still rendered on the button

main	This branch

pkgload::load_all("teal.widgets")
library(teal.code)
library(shiny)

ui <- fluidPage(
  verbatim_popup_ui("pop", "Warnings")
)

server <- function(input, output, session) {

  disabled <- reactive({
    validate(need(FALSE, "This is a validation but it is being shown!"))
    FALSE
  })

  verbatim_popup_srv(
    "pop",
    title = "boo",
    verbatim_content = reactive("Hello"),
    disabled = disabled
  )
}

shinyApp(ui, server)

[gogonzo]

Can we just include useShinyjs() in the UI of this element. It's a singleton so multiple calls shouldn't make a difference.

[gogonzo]

@Polkas what about this? Would you agree to include shinyjs::useShinyjs so we don't need to notify anyone.

[Polkas]

the package has the shinyjs dependency so not including it will NOT reduce the dependency for sb who want to use this functionality.
Then I agree with you that adding shinyjs::useShinyjs it is a good move.

[gogonzo]

👍