Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme updates #191

Merged
merged 4 commits into from
Sep 14, 2023
Merged

readme updates #191

merged 4 commits into from
Sep 14, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Sep 12, 2023

@m7pr m7pr added the core label Sep 12, 2023
@m7pr m7pr requested a review from donyunardi September 12, 2023 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            225     182  19.11%   87-362, 414, 465, 471, 486-499
R/panel_group.R               90      90  0.00%    12-132
R/plot_with_settings.R       382      21  94.50%   272-285, 344-345, 356-357, 607-608, 610, 612
R/standard_layout.R           35       0  100.00%
R/table_with_settings.R      173       1  99.42%   79
R/utils.R                     11       1  90.91%   7
R/verbatim_popup.R            99      49  50.51%   63-78, 104-105, 107, 115-143, 164
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1196     447  62.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 19f77fd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr enabled auto-merge (squash) September 12, 2023 14:26
@kartikeyakirar
Copy link
Contributor

Should the keyword widget be in a code block or shown without backticks?

image

README.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    10 suites   19s ⏱️
101 tests 101 ✔️ 0 💤 0
208 runs  208 ✔️ 0 💤 0

Results for commit 502cc99.

@m7pr m7pr requested a review from donyunardi September 13, 2023 09:09
@m7pr
Copy link
Contributor Author

m7pr commented Sep 13, 2023

Thanks @kartikeyakirar . Just removed those in 1fb82de

@kartikeyakirar
Copy link
Contributor

GitHub Pages automatically searches for an index.html file, so is it necessary to include "index.html" at the end of the URL? I was just was curious 🤔

@m7pr
Copy link
Contributor Author

m7pr commented Sep 13, 2023 via email

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m7pr m7pr merged commit 3428dde into main Sep 14, 2023
@m7pr m7pr deleted the readme@main branch September 14, 2023 06:05
This was referenced Sep 27, 2023
m7pr added a commit that referenced this pull request Sep 29, 2023
Continuation of
#191 and a part
of #189

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants