Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes width problem in plot_with_settings #273

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes #272

@averissimo averissimo enabled auto-merge (squash) November 26, 2024 13:03
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          383      23  93.99%   283-296, 318, 355-356, 367-368, 384, 654-655, 657, 659
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1246     495  60.27%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/plot_with_settings.R      +10      +1  -0.11%
TOTAL                       +10      +1  +0.24%

Results for commit: 1e403ae

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr self-assigned this Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Tests Summary

  1 files   11 suites   1m 21s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
334 runs  334 ✅ 0 💤 0 ❌

Results for commit 1e403ae.

♻️ This comment has been updated with latest results.

@averissimo averissimo merged commit 061738f into main Nov 26, 2024
26 checks passed
@averissimo averissimo deleted the 1187_decorate_output@main branch November 26, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when plot_width not given and default_width not updated in time
2 participants