Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove red bg style for draggable bucket #284

Merged
merged 1 commit into from
Jan 29, 2025
Merged

remove red bg style for draggable bucket #284

merged 1 commit into from
Jan 29, 2025

Conversation

donyunardi
Copy link
Contributor

Fixes #283

@donyunardi donyunardi requested a review from vedhav January 29, 2025 19:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Unit Tests Summary

  1 files   11 suites   1m 26s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
334 runs  334 ✅ 0 💤 0 ❌

Results for commit 0761cee.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💚 $42.81$ $-2.13$ $0$ $0$ $0$ $0$

Results for commit 51c2a36

♻️ This comment has been updated with latest results.

vedhav
vedhav approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I see that was the last one. Thanks for catching it.

@donyunardi donyunardi merged commit a323c4d into main Jan 29, 2025
26 checks passed
@donyunardi donyunardi deleted the 283_remove_red_bg_draggable@main branch January 29, 2025 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vedhav vedhav vedhav approved these changes

Assignees

@vedhav vedhav

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

red background for draggable bucket
2 participants
@donyunardi @vedhav