Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the code chunks does not break because of warnings #287

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Make sure the code chunks does not break because of warnings #287

merged 1 commit into from
Jan 30, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 30, 2025

Part of vignette review insightsengineering/nestdevs-tasks#99

@vedhav vedhav added the core label Jan 30, 2025
@vedhav vedhav mentioned this pull request Jan 30, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Tests Summary

  1 files   11 suites   1m 28s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
334 runs  334 ✅ 0 💤 0 ❌

Results for commit 38ae850.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
table_with_settings_ui 💚 $33.19$ $-1.26$ $0$ $0$ $0$ $0$

Results for commit 2488242

♻️ This comment has been updated with latest results.

@donyunardi donyunardi self-assigned this Jan 30, 2025
@donyunardi donyunardi merged commit 2c44890 into main Jan 30, 2025
29 checks passed
@donyunardi donyunardi deleted the 99-vignette-review@main branch January 30, 2025 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@donyunardi donyunardi donyunardi approved these changes

Assignees

@donyunardi donyunardi

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedhav @donyunardi