Add partial (client) binding support for BSD #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 75.31% 75.31%
=======================================
Files 68 68
Lines 3083 3083
=======================================
Hits 2322 2322
Misses 665 665
Partials 96 96Continue to review full report at Codecov.
|
|
@dmgk Thanks for your contribution! Doesn't it need a build constraint / build tag? |
|
@pmazzini It does have one, currently constraining the build to freebsd, openbsd and netbsd only: https://github.com/insomniacslk/dhcp/pull/260/files#diff-e78aed4e493232b381170e9512c08c72R1 |
pmazzini
approved these changes
Mar 13, 2019
|
@dmgk Would you mind closing and reopening the PR (it is just two clicks) to trigger a new travis build? |
|
@dmgk Thanks for your contribution! |
|
@pmazzini Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #240