Bind interface fix

[borna-blazevic]

Created a new bind to interface function for v4 server, and altered v4 server.go to make it more consistent with the v6 server.

[codecov]

Codecov Report

Merging #310 into master will increase coverage by 0.13%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   73.12%   73.26%   +0.13%     
==========================================
  Files          75       76       +1     
  Lines        3725     3725              
==========================================
+ Hits         2724     2729       +5     
+ Misses        867      857      -10     
- Partials      134      139       +5

Impacted Files	Coverage Δ
dhcpv4/nclient4/conn_linux.go	64.7% <ø> (+15.45%)	⬆️
dhcpv4/server4/server.go	58.53% <100%> (ø)	⬆️
dhcpv4/server4/conn.go	31.25% <31.25%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0d21c...a37cf60. Read the comment docs.

[pmazzini]

Thanks for the PR @borna-blazevic!

[pmazzini]

nclient4/client_test.go needs to be updated: https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/nclient4/client_test.go#L64

server4/server_test.go needs to be updated: https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/server4/server_test.go#L76

[borna-blazevic]

nclient4/client_test.go needs to be updated: https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/nclient4/client_test.go#L64

server4/server_test.go needs to be updated: https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/server4/server_test.go#L76

From where should I pass the interface in client_test.go?

[pmazzini]

From where should I pass the interface in client_test.go?

Which interface are you referring to? In client_test.go I think you should change line 64:

From:

s, err := server4.NewServer(nil, h.handle, server4.WithConn(serverConn))

To:

s, err := server4.NewServer("", nil, h.handle, server4.WithConn(serverConn))

[pmazzini]

For reference, this PR comes from coredhcp/coredhcp#40

[borna-blazevic]

@pmazzini made the changes you asked for.

[pmazzini]

Thanks for addressing those comments. Travis is now showing a circular dependency:

import cycle not allowed in test
package github.com/insomniacslk/dhcp/dhcpv4/nclient4 (test)
	imports github.com/insomniacslk/dhcp/dhcpv4/server4
	imports github.com/insomniacslk/dhcp/dhcpv4/nclient4
FAIL	github.com/insomniacslk/dhcp/dhcpv4/nclient4 [setup failed]

How about moving NewIPv4UDPConn from nclient4/conn_linux.go to server4/conn_linux.go since that function is only used by the server package.

I think that should solve the circular dependency problem.

We can later see a better organization for it. Maybe creating a conn package.

[pmazzini]

server4/server_test.go needs to be updated https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/server4/server_test.go#L84

dhcpv4/server4/server_test.go:84:21: undefined: nclient4.NewIPv4UDPConn

[pmazzini]

lgtm after those 2 last comments

[pmazzini]

Can conn_linux.go inside server4 be renamed to conn.go? I've just noticed that is not linux specific.

[pmazzini]

Thanks for working on this @borna-blazevic! It looks ok to me.

Can you check if the v4 work that you are doing in coredhcp/coredhcp#40 works fine with this change?

[pmazzini]

I am not merging it yet to let other people have a look as well.

[borna-blazevic]

Thanks for working on this @borna-blazevic! It looks ok to me.

Can you check if the v4 work that you are doing in coredhcp/coredhcp#40 works fine with this change?

Yes it works fine