Fix inspec detect on SLES

[christian-wtd]

This is a fix for the broken remote execution of Inspec on SUSE SLES 12.

Description

More details can be found in inspec/inspec#4384

Basically the problem appears for non-root users with sudosh blocking OS detection without sudo and blocks any inspec run for remote operations. Neither the /etc/os-release file is readable nor the uname command is executable without sudo in such an environment.

This has been verified working with Inspec CLI and also Inspec Library Runner Class.

Related Issue

inspec/inspec#4384

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New content (non-breaking change)
• Breaking change (a content change which would break existing functionality or processes)

Checklist:

• I have read the CONTRIBUTING document.

[chef-expeditor]

Hello christian-wtd! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[christian-wtd]

Hello,

did anyone already had a chance to look at this?

Best regards
Christian

[clintoncwolfe]

Hi @christian-wtd - Thanks for the contribution! You traced a problem across two software projects and found where to fix it, which is not easy - good work! Here's what I'd like to see to get this merged in:

1. A refactor to move the conditional logic into one place
2. If possible, try to read the sudo option from the @backend connection object rather than straight from @ARGV. That's safer - for example, --sudo might be abbreviated on the command line, or passed differently on the Runner API.

A great start!

[christian-wtd]

Ok. now I have fucked up GIT somehow :-(
there should be only one commit left for the
lib/train/transports/ssh_connection.rb
but I mixed it up.

[codeclimate]

Code Climate has analyzed commit 27187a5 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2

View more on Code Climate.

[christian-wtd]

So having the different approach now in the correct file we should be good to go and also we no longer use ARGV.
Single place, less code and more appropriate place.

[christian-wtd]

the reference I made was wrong, should have pointed to my other pull request.

[clintoncwolfe]

This looks correct to me - thanks!

[christian-wtd]

Any ETA when this gets merged and released?

[christian-wtd]

@miah & @clintoncwolfe :
It's nearly 2 months after approval, when this will be merged and released?

[christian-wtd]

Thank you very much!

[zenspider]

This PR might need to be rolled back as it is causing severe problems in other areas (eg #538) and it is too hard to debug. It should probably also have had a test added before it was merged.

Further, I'm running sles 12 in a docker container and both uname and /etc/os-release are fine without sudo, so I'm really not sure what this is solving yet.

Finally, given the 9 commits vs the final diff, this should have been squashed or interactive rebased and cleaned up.

[zenspider]

This has been addressed via #544.