Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global is not exists in browser #11

Closed
wants to merge 1 commit into from
Closed

global is not exists in browser #11

wants to merge 1 commit into from

Conversation

QiYuTechDev
Copy link

ljharb
ljharb requested changes Jul 28, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global works in node, and any non-broken bundler will turn it into window.

This change would be a breaking change, since it would fail in any node or browser version that lacks globalThis.

@ljharb
Copy link
Member

ljharb commented Jul 28, 2021

Duplicate of #8. Duplicate of #10.

@ljharb ljharb closed this Jul 28, 2021
@QiYuTechDev QiYuTechDev mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QiYuTechDev @ljharb