Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/re add autorom #302

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Chore/re add autorom #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3da5942
fix(PZ): Re-added autorom.
KaleabTessera Aug 20, 2021
46e5a99
fix(ci): Removed system tests from github action runs.
KaleabTessera Aug 19, 2021
4df0545
fix(ci): Tmp force github actions to invalidate autorom cache.
KaleabTessera Aug 20, 2021
f778b70
fix(ci): Remove manual autorom cache invalidate.
KaleabTessera Aug 20, 2021
07e3db0
Merge branch 'develop' into chore/re-add-autorom
KaleabTessera Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,8 @@ jobs:

# For atari envs
sudo apt-get install unrar
# Temp fix untill autorom works again
# pip install autorom
# AutoROM -v
wget http://www.atarimania.com/roms/Roms.rar
unrar x Roms.rar
sudo apt-get install unzip -y
unzip ROMS.zip
python -m atari_py.import_roms ROMS
rm Roms.rar ROMS.zip "HC ROMS.zip"
pip install autorom
AutoROM -v

## Fix module 'enum' has no attribute 'IntFlag'
pip uninstall -y enum34
Expand All @@ -78,7 +71,7 @@ jobs:
mypy . --exclude docs/
- name: Test with pytest and get code coverage
run: |
pytest -n "$(grep -c ^processor /proc/cpuinfo)" tests
pytest -n "$(grep -c ^processor /proc/cpuinfo)" tests --ignore-glob="*/*system_test.py"
- name: Check docstring code coverage
run: |
interrogate -c pyproject.toml
11 changes: 2 additions & 9 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,8 @@ ENV TF_CPP_MIN_LOG_LEVEL=3

# PettingZoo
RUN apt-get install unrar
# RUN python -m pip install autorom
# RUN AutoROM -v
# Temp fix untill autorom works again
RUN wget http://www.atarimania.com/roms/Roms.rar
RUN unrar x Roms.rar
RUN sudo apt-get install unzip -y
RUN unzip ROMS.zip
RUN python -m atari_py.import_roms ROMS
RUN rm Roms.rar ROMS.zip "HC ROMS.zip"
RUN python -m pip install autorom
RUN AutoROM -v

# cmake and clang for openspiel
RUN apt-get install clang -y
Expand Down