Feature/recurrent and multiple trainer MAPPO #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks so much @DriesSmit 👐 This is really great! Just see my minor comments.
arnupretorius
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Thanks @DriesSmit! 👍 Did a quick smoke review. Left minor comments. Happy with the benchmarking on this and will be useful for comparing with Jax systems.
examples/tf/debugging/simple_spread/recurrent/state_based/run_mappo.py
Outdated
Show resolved
Hide resolved
KaleabTessera
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Thanks @DriesSmit , great work on getting this in 🔥 👐 🔥
Just a minor commont on adding doc strings for fix_sampler.
DriesSmit
dismissed stale reviews from KaleabTessera and arnupretorius
via
60eb054
KaleabTessera
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add recurrent training capabilities to MAPPO. Migrate MAPPO to now use the centralised variable source. This allows for training using multiple trainers.
Why?
This update allows for the use of MAPPO in the recurrent training setting and with multiple trainers.
How?
Adapted the MAPPO trainer to work in the recurrent setting. Added a recurrent executor to MAPPO. Migrated the old MAPPO code to use the new scaling version of Mava.
Extra
.