Feature/auto-push-docker-images and version upgrades #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaleabTessera
requested review from
arnupretorius and
DriesSmit
as code owners
DriesSmit
approved these changes
Dec 13, 2021
mmorris44
suggested changes
Dec 13, 2021
| @@ -6,6 +6,7 @@ on: | |||
| pull_request: | |||
| branches: [develop] | |||
|
|
|||
| # TODO(Kale-ab) Specify mava container to run tests on. | |||
There was a problem hiding this comment.
TODO still un-done. Is this for a future PR?
There was a problem hiding this comment.
Yes. Once we have an instadeepct dockerhub account, I will pull a container from there in the workflow. Currently, we are using my personal dockerhub so I haven't added it here.
| @@ -4,6 +4,7 @@ on: | |||
| pull_request: | |||
| branches: [main] | |||
|
|
|||
| # TODO(Kale-ab) Specify mava container to run tests on. | |||
There was a problem hiding this comment.
Commented above.
| @@ -1,6 +1,6 @@ | |||
| ########################################################## | |||
| # Core Mava image | |||
| FROM nvcr.io/nvidia/cuda:11.4.2-cudnn8-runtime-ubuntu20.04 as mava-core | |||
| FROM registry.kao.instadeep.io/library/nvidia/cuda:11.4.2-cudnn8-runtime-ubuntu20.04 as mava-core | |||
There was a problem hiding this comment.
Is this standard practice for us going forward? To use a InstaDeep-hosted image rather than an nividia one?
mmorris44
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ModuleNotFoundError: No module named 'chex'.Why?
How?
Extra