Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: benchmarking issue template #385

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

arnupretorius
Copy link
Collaborator

What?

Issue template for benchmarking tasks.

Why?

To organise/plan benchmarking work.

How?

Add markdown template.

closes #382

@arnupretorius arnupretorius self-assigned this Feb 3, 2022
@arnupretorius arnupretorius added the enhancement New feature or request label Feb 3, 2022
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Is the general idea here that we would always open an issue on github before we run benchmarks?

@arnupretorius
Copy link
Collaborator Author

I think this looks good. Is the general idea here that we would always open an issue on github before we run benchmarks?

Yes, that would be the idea. I would also like us to have benchmark results be visible on the repo itself, so in the future benchmarking will move closer to Mava as opposed to the results only being available on the experiment runner.

@RuanJohn
Copy link
Collaborator

RuanJohn commented Feb 3, 2022

I think this looks good. Is the general idea here that we would always open an issue on github before we run benchmarks?

Yes, that would be the idea. I would also like us to have benchmark results be visible on the repo itself, so in the future benchmarking will move closer to Mava as opposed to the results only being available on the experiment runner.

Sounds good.

RuanJohn
RuanJohn previously approved these changes Feb 3, 2022
KaleabTessera
KaleabTessera previously approved these changes Feb 4, 2022
Copy link
Contributor

@KaleabTessera KaleabTessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor comment.

.github/ISSUE_TEMPLATE/benchmarking_internal.md Outdated Show resolved Hide resolved
Copy link
Contributor

@KaleabTessera KaleabTessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnupretorius !

Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Thank you @arnupretorius :)

@arnupretorius arnupretorius merged commit 0cc5e08 into develop Feb 7, 2022
@arnupretorius arnupretorius deleted the feature/internal-benchmarking-issue-template branch February 7, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Internal benchmarking issue template for dev team
3 participants