-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: benchmarking issue template #385
feat: benchmarking issue template #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Is the general idea here that we would always open an issue on github before we run benchmarks?
Yes, that would be the idea. I would also like us to have benchmark results be visible on the repo itself, so in the future benchmarking will move closer to Mava as opposed to the results only being available on the experiment runner. |
Sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor comment.
cdcf027
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arnupretorius !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Thank you @arnupretorius :)
What?
Issue template for benchmarking tasks.
Why?
To organise/plan benchmarking work.
How?
Add markdown template.
closes #382