Fix/architecture typo fix. #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuanJohn
requested review from
arnupretorius,
KaleabTessera,
DriesSmit,
mmorris44,
AsadJeewa and
jcformanek
as code owners
RuanJohn
changed the title
arnupretorius
approved these changes
Feb 16, 2022
KaleabTessera
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There was a small typo in the
network.pyfiles for the MADDPG and MAD4PG implementations. Subsequently, it also showed up in some MADDPG/MAD4PG examples and tests. It was also in a few MADQN docstrings and examples.Why?
It was fixed because it caused problems with benchmarking and experiment runner where some systems could accept
architecture_typeas a parameter and others required a manual change toarchecture_type.How?
Fixed the typo in all files that it appeared in.
Extra
The system level tests for MADDPG, MAD4PG and MADQN all pass after the typo fix.