Feature/jax mava custom config class #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnupretorius
requested review from
DriesSmit,
mmorris44,
AsadJeewa,
RuanJohn and
jcformanek
as code owners
KaleabTessera
previously approved these changes
Feb 24, 2022
There was a problem hiding this comment.
This is excellent @arnupretorius , super excited to use this.
I just made some minor comments. My biggest comment is that it should be obvious what we are getting/setting when we call add,update,get,set. This are all called like config. , but some apply to self._config and others to self._built_config. This might be a bit confusing when using it.
DriesSmit
reviewed
Feb 24, 2022
RuanJohn
reviewed
Feb 24, 2022
arnupretorius
commented
Feb 24, 2022
RuanJohn
approved these changes
Feb 25, 2022
DriesSmit
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Config handler class for Jax based Mava systems.
Why?
More flexible configs that dynamically change with the component setup of a system.
How?
Implement a config class with methods to handle adding and updating config dataclass for different system components and updating config hyperparameters.
closes #411