Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated docs to better represent available options #448

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

sash-a
Copy link
Contributor

@sash-a sash-a commented Mar 2, 2022

What?

issue #447

Updated docs to better represent available options for mixer networks in value decomposition

Why?

It was not clear that I could use the strings "qmix" or "vdn" when looking at the docs. (Thanks @jcformanek for pointing this out)

How?

Docs are updated to indicate this is possible and argument type is changed to Union[snt.Module, str]

@sash-a sash-a added the documentation Improvements or additions to documentation label Mar 2, 2022
Copy link
Contributor

@AsadJeewa AsadJeewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sasha

@sash-a sash-a merged commit e60a4dc into develop Mar 2, 2022
@sash-a sash-a deleted the maintain/value-decomp-docs branch March 2, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants