Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ Update PZ Version and new jax dockerfiles #480

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Bugfix/ Update PZ Version and new jax dockerfiles #480

merged 8 commits into from
Apr 20, 2022

Conversation

KaleabTessera
Copy link
Contributor

@KaleabTessera KaleabTessera commented Apr 19, 2022 •
edited
Loading

What?

  • Updated pz env version.
  • Added dockerfile and requirements for jax.

Why?

  • Smac wrapper uses latest version of pz, that causes an error when importing smac.
  • New jax images help resolve a bug with version of jax.

How?

Extra

Closes #479.

@KaleabTessera KaleabTessera self-assigned this Apr 19, 2022
DriesSmit
DriesSmit approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@DriesSmit DriesSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @KaleabTessera 🙂 🔥

RuanJohn
RuanJohn approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KaleabTessera 💪

@KaleabTessera KaleabTessera merged commit fe5389d into develop Apr 20, 2022
@KaleabTessera KaleabTessera deleted the bugfix/update-pz-docker-for-jax branch April 20, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuanJohn RuanJohn RuanJohn approved these changes

@DriesSmit DriesSmit DriesSmit approved these changes

@arnupretorius arnupretorius Awaiting requested review from arnupretorius

@mmorris44 mmorris44 Awaiting requested review from mmorris44

@AsadJeewa AsadJeewa Awaiting requested review from AsadJeewa

@jcformanek jcformanek Awaiting requested review from jcformanek

Assignees

@KaleabTessera KaleabTessera

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Importing smac fails due PZ version
3 participants
@KaleabTessera @DriesSmit @RuanJohn