-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Clean up dev dependencies + bump versions #418
Conversation
eab4890
to
845a493
Compare
b5714df
to
ee36377
Compare
- mocha@8 requires Node >= 10 - update in v2
e47a4f5
to
ef59d68
Compare
ef59d68
to
197a1ba
Compare
Also closing this PR after thinking about it another time. lerna/lerna#3029 is in our way. It is impossible to move common dependencies to the root if we always have to take care that lerna does not mess up our lock file. On top of that we are running into npm/cli#4084. It forces us to use legacy peer deps option, which we don't want, because this will install a wrong dependency tree. This might lead to wrong assumptions in our test env. I think we should only do a few smaller clean up steps and then leave it as it is:
|
Conclusion:
|
refs 75234
refs 80052
See advantages:
https://github.com/lerna/lerna#common-devdependencies
before:
real 6m47.953s
user 5m49.277s
sys 3m34.443s
after: