Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Clean up dev dependencies + bump versions #418

Closed
wants to merge 13 commits into from

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Nov 16, 2021

refs 75234
refs 80052

See advantages:
https://github.com/lerna/lerna#common-devdependencies


before:
real 6m47.953s
user 5m49.277s
sys 3m34.443s

after:

@kirrg001 kirrg001 force-pushed the fix/devdependencies2 branch 2 times, most recently from e47a4f5 to ef59d68 Compare November 28, 2021 08:11
@kirrg001 kirrg001 force-pushed the fix/devdependencies2 branch from ef59d68 to 197a1ba Compare November 28, 2021 08:20
@kirrg001
Copy link
Contributor Author

Also closing this PR after thinking about it another time.

lerna/lerna#3029 is in our way. It is impossible to move common dependencies to the root if we always have to take care that lerna does not mess up our lock file.

On top of that we are running into npm/cli#4084. It forces us to use legacy peer deps option, which we don't want, because this will install a wrong dependency tree. This might lead to wrong assumptions in our test env.

I think we should only do a few smaller clean up steps and then leave it as it is:

  • ensure major versions (such as mocha, semver etc) of dev dependencies are equal
  • general update of dev dependencies
  • add some lerna dependency docs (how to use it - some workflows should be documented IMO)
  • removal of unused dependencies
  • research if there is more

@kirrg001 kirrg001 closed this Nov 28, 2021
@kirrg001
Copy link
Contributor Author

kirrg001 commented Nov 29, 2021

Conclusion:

  • we have the option to add rules how to use lerna with common dev dependencies on root
  • we look at it with a pair of new eyes (in a new PR)

@kirrg001 kirrg001 deleted the fix/devdependencies2 branch September 23, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant