travis: update to use liblua5.4 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but instead is not compatible with lua 5.4. So, only 5.1-5.3 can be used. |
|
@gl00my, thanks for confirming, that fits my expectation. Do you folks have support plan for Lua 5.4? |
|
Currently, no. We are using luajit mostly, and in games we are using const function, that in 5.4 become keyword. So, i think instead will stayed on low versions. |
|
Got you, that is helpful context. Thanks! |
|
In fact, i just compiled instead with lua5.4 and it works. There was small fix needed, it is in git now. You may try it. |
|
Will try out later, thanks for the fix! |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to upgrade lua formula to 5.4.0, but found the instead actually does not quite work with the latest lua, so bump the liblua to 5.4 in here.