This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
fix(docs): fix tasks.json inconsistent issue #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglin
requested review from
GeorgeWilliamStrong,
donch1989,
xiaofei-du and
jvallesm
as code owners
jvallesm
approved these changes
Sep 30, 2024
| @@ -227,7 +227,7 @@ | |||
| "reference", | |||
| "template" | |||
| ], | |||
| "title": "System message", | |||
| "title": "System Message", | |||
There was a problem hiding this comment.
nit: we should either document that titles must be title-cased in the contribution guidelines, or use the titleCaseWithArticles function in the template to unify the titles across the documents. If we don't care particularly about the JSON definition, I'd go with the second option.
jvallesm
added a commit
to instill-ai/pipeline-backend
that referenced
this pull request
Oct 18, 2024
Because - We relied on writing property titles with Title Case manually (e.g. instill-ai/component#381, instill-ai/component#361). This commit - Uses Title Case for property titles, too - Extends lowercase dictionary - Extends uppercase dictionary - Respects capitalization of lowercase words if at the end of the title - Respects capitalization of uppercase words if pluralized - Adds unchanged words - Moves dash (-) and underscore (_) replacement to anchor generation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
tasks.jsonfiles.instillUIOrdervalue causes the generatedREADME.mdxinconsistentThis commit