This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
chore: rename blockchain type to application #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When validating the field for README autogeneration, the field didn't pass go-playground/validator `url` validator. - When rendering the value in a README, it reference a relative path instead of an absolute one. Automatically updated with some `jq` magic: ```sh for p in $(fd definitions.json); do jq '.[0].source_url = "https://" + .[0].source_url ' $p > tmp.json && mv tmp.json $p done; ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 62.18% 62.18%
=======================================
Files 18 18
Lines 1489 1489
=======================================
Hits 926 926
Misses 440 440
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
force-pushed
the
jvalles/ins-3739-rename-blockhain-type-to-application
branch
from
e2cbc97 to
041e2fc
Compare
jvallesm
requested review from
donch1989,
pinglin and
xiaofei-du
as code owners
This was referenced Feb 26, 2024
donch1989
approved these changes
Feb 27, 2024
jvallesm
deleted the
jvalles/ins-3739-rename-blockhain-type-to-application
branch
jvallesm
added a commit
to instill-ai/pipeline-backend
that referenced
this pull request
Feb 27, 2024
Because - instill-ai/protobufs#274 removed the Blockchain connector type and modified the connector and operator list view type. - Once instill-ai/connector#131 is merged, `numbers` connector will become an application connector. This commit - Updates the auto-generated proto Go code, adapting the backend to the changes: - Modifies the Blockchain enum value in the database via a migration. - Modifies type conversions to take Application connector into account. - Removes deprecated lookup methods. - Updates `VIEW_XXX` enum values.
EiffelFly
pushed a commit
to instill-ai/console
that referenced
this pull request
Feb 28, 2024
Because - instill-ai/protobufs#274 removed the Blockchain connector type. - Once instill-ai/connector#131 is merged, `numbers` connector will become an application connector. This commit - Updates `blockchain` references to `application`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Notes
consoleandpipeline-backendneed to take this change into account, otherwise the UI will break.