chore(integration): allow only OAuth connections once that method is …

…supported
instill-ai · Oct 4, 2024 · 0137e98 · 0137e98
1 parent f5663cf
commit 0137e98
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/integration-test/pipeline/rest-integration.js b/integration-test/pipeline/rest-integration.js
@@ -117,7 +117,9 @@ export function CheckConnections(data) {
       pipelinePublicHost + path,
       JSON.stringify({
         id: connectionID,
-        integrationId: integrationID,
+        // Needs to be an integration that doesn't support OAuth. Once it's
+        // supported, it's the only method allowed.
+        integrationId: "asana",
         method: "METHOD_DICTIONARY",
         setup: setup,
       }),

diff --git a/pkg/service/integration.go b/pkg/service/integration.go
@@ -194,6 +194,9 @@ func (s *service) validateConnection(conn *pb.Connection, integration *pb.Integr
 	switch conn.GetMethod() {
 	case pb.Connection_METHOD_DICTIONARY:
 		err := fmt.Errorf("%w: invalid payload in dictionary connection", errdomain.ErrInvalidArgument)
+		if integration.GetOAuthConfig() != nil {
+			return errmsg.AddMessage(err, integration.GetTitle()+" connection only accepts METHOD_OAUTH.")
+		}
 		if len(conn.GetScopes()) > 0 {
 			return errmsg.AddMessage(err, "Scopes only apply to OAuth connections.")
 		}