fix: fix duration configuration bug

instill-ai · Jun 13, 2022 · 998eafa · 998eafa
1 parent 962823b
commit 998eafa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/config/config.yaml b/config/config.yaml
@@ -21,7 +21,7 @@ database:
   pool:
     idleconnections: 5
     maxconnections: 10
-    connlifetime: 30 # In minutes
+    connlifetime: 30m # In minutes, e.g., '60m'
 cache:
   redis:
     redisoptions:

diff --git a/internal/db/db.go b/internal/db/db.go
@@ -3,7 +3,6 @@ package db
 import (
 	"fmt"
 	"sync"
-	"time"
 
 	"gorm.io/driver/postgres"
 	"gorm.io/gorm"
@@ -48,11 +47,12 @@ func GetConnection() *gorm.DB {
 		// SetMaxOpenConns sets the maximum number of open connections to the database.
 		sqlDB.SetMaxOpenConns(databaseConfig.Pool.MaxConnections)
 		// SetConnMaxLifetime sets the maximum amount of time a connection may be reused.
-		sqlDB.SetConnMaxLifetime(time.Minute * databaseConfig.Pool.ConnLifeTime)
+		sqlDB.SetConnMaxLifetime(databaseConfig.Pool.ConnLifeTime)
 	})
 	return db
 }
 
+// Close closes the db connection
 func Close(db *gorm.DB) {
 	// https://github.com/go-gorm/gorm/issues/3216
 	//