Skip to content

Commit

Permalink
fix(controller): fix rename id and execution order (#148)
Browse files Browse the repository at this point in the history
Because

- failing integration-test with pipeline renaming

This commit

- fix delete/update resource execution order
- fix id/newid
  • Loading branch information
heiruwu authored May 5, 2023
1 parent 1431c26 commit ae29a07
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -419,15 +419,15 @@ func (s *service) UpdatePipelineID(id string, owner *mgmtPB.User, newID string)
return nil, status.Errorf(codes.NotFound, "Pipeline id %s is not found", id)
}

if err := s.repository.UpdatePipelineID(id, ownerPermalink, newID); err != nil {
if err := s.DeleteResourceState(fmt.Sprintf("pipelines/%s", id)); err != nil {
return nil, err
}

if err := s.DeleteResourceState(fmt.Sprintf("pipelines/%s", existingPipeline.ID)); err != nil {
if err := s.repository.UpdatePipelineID(id, ownerPermalink, newID); err != nil {
return nil, err
}

if err := s.UpdateResourceState(fmt.Sprintf("pipelines/%s", id), pipelinePB.Pipeline_State(existingPipeline.State), nil); err != nil {
if err := s.UpdateResourceState(fmt.Sprintf("pipelines/%s", newID), pipelinePB.Pipeline_State(existingPipeline.State), nil); err != nil {
return nil, err
}

Expand Down

0 comments on commit ae29a07

Please sign in to comment.