feat: support reference with foo["bar"] syntax
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
========================================
- Coverage 0.71% 0.70% -0.01%
========================================
Files 8 8
Lines 2949 2973 +24
========================================
Hits 21 21
- Misses 2928 2952 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
requested review from
pinglin,
xiaofei-du and
jvallesm
as code owners
jvallesm
approved these changes
Feb 23, 2024
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-02-29) ### Features * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Miscellaneous Chores * release v0.23.0-beta ([53fbd18](53fbd18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-02-29) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Miscellaneous Chores * release v0.23.0-beta ([4d5639b](4d5639b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 1, 2024
donch1989
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-03-01) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Bug Fixes * fix component ID with a hyphen cannot be referenced ([#401](#401)) ([1958168](1958168)) ### Miscellaneous Chores * release v0.23.0-beta ([e3ab340](e3ab340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
foo.barsyntax. However, this approach failed when dealing with a key containing a space. To address this limitation, we needed to implement support for the child operator infoo["bar"]syntax. This change ensures that keys likemy varcan function correctly withfoo["my var"].This commit
foo["bar"]syntax.Note
openapi.gois very messy, we'll refactor it soon.